Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the proper remote repo for the signatures on verify #1243

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Log the proper remote repo for the signatures on verify #1243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd/cosign/cli/sign/sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ func signDigest(ctx context.Context, digest name.Digest, payload []byte, ko KeyO
return errors.Wrap(err, "constructing client options")
}

fmt.Fprintln(os.Stderr, "Pushing signature to:", digest.Repository)
// Check if we are overriding the signatures repository location
repo, _ := ociremote.GetEnvTargetRepository()
if repo.RepositoryStr() == "" {
fmt.Fprintln(os.Stderr, "Pushing signature to:", digest.Repository)
} else {
fmt.Fprintln(os.Stderr, "Pushing signature to:", repo.RepositoryStr())
}

// Publish the signatures associated with this entity
if err := ociremote.WriteSignatures(digest.Repository, newSE, walkOpts...); err != nil {
Expand Down