Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify-blob to support DSSEs #1355

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

rgreinho
Copy link
Contributor

Adds the ability to verify DSSEs from the verify-blob command.

Fixes #1321

@dlorenc
Copy link
Member

dlorenc commented Jan 25, 2022

cc @priyawadhwa

@rgreinho
Copy link
Contributor Author

Using the signature and the envelope I put in the issue, I used it like that:

$ ./cosign verify-blob --key cosign.pub --signature dsse.sig dsse.sig
Verified OK

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @rgreinho ! Just added one comment about unit testing :)

cmd/cosign/cli/verify/verify_blob.go Outdated Show resolved Hide resolved
@rgreinho rgreinho force-pushed the dsse-check branch 2 times, most recently from 2049796 to c925381 Compare January 25, 2022 21:48
Adds the ability to verify DSSEs from the `verify-blob` command.

Fixes sigstore#1321

Signed-off-by: Rémy Greinhofer <[email protected]>
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rgreinho !

@dlorenc dlorenc merged commit 21e6b80 into sigstore:main Jan 26, 2022
@github-actions github-actions bot added this to the v1.5.1 milestone Jan 26, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Adds the ability to verify DSSEs from the `verify-blob` command.

Fixes sigstore#1321

Signed-off-by: Rémy Greinhofer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DSSE support to verify-attestation
3 participants