Streamline SignBlobCmd API with SignCmd
#1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `SignCmd` we do not pass a context any more but use the timeout from the root options. This is now done in `SignBlobCmd` too. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
sign-blob-ctx
branch
from
e5615b0 to
6b1ddbc
Compare
dlorenc
approved these changes
Feb 14, 2022
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
In `SignCmd` we do not pass a context any more but use the timeout from the root options. This is now done in `SignBlobCmd` too. Signed-off-by: Sascha Grunert <[email protected]>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
In `SignCmd` we do not pass a context any more but use the timeout from the root options. This is now done in `SignBlobCmd` too. Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
SignCmdwe do not pass a context any more but use the timeout fromthe root options. This is now done in
SignBlobCmdtoo.Ticket Link
None
Release Note