Use latest knative/pkg's configmap informer #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnghia
force-pushed
the
use-dynamic-cm-informers
branch
from
bb02814 to
544cc6b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
- Coverage 27.99% 27.94% -0.06%
==========================================
Files 137 137
Lines 7826 7820 -6
==========================================
- Hits 2191 2185 -6
Misses 5405 5405
Partials 230 230
Continue to review full report at Codecov.
|
vaikas
reviewed
Mar 16, 2022
|
|
||
| // Start the informers we got from the SharedInformerFactory above because | ||
| // injection doesn't do that for us since we're injecting the Factory and | ||
| // not the informers. | ||
| if err := controller.StartInformers(ctx.Done(), nsSecretInformer.Informer(), nsConfigMapInformer.Informer()); err != nil { | ||
| if err := controller.StartInformers(ctx.Done(), secretInformer.Informer(), configMapInformer.Informer()); err != nil { |
There was a problem hiding this comment.
I know this is just a draft, but jotting this down.
Now that both of these are coming from the informers, instead of the factory, I think we do not need to manually start them.
https://github.com/knative/pkg/blob/main/injection/clients/namespacedkube/informers/core/v1/configmap/configmap.go#L36
For example, above, registers cm informer, so it should be started automagically by the sharedwithmain.
There was a problem hiding this comment.
Yeah, we should drop this. Good catch.
tcnghia
force-pushed
the
use-dynamic-cm-informers
branch
from
860b938 to
aff929d
Compare
mattmoor
approved these changes
Mar 16, 2022
hectorj2f
approved these changes
Mar 16, 2022
cpanato
approved these changes
Mar 16, 2022
tcnghia
force-pushed
the
use-dynamic-cm-informers
branch
3 times, most recently
from
de13aea to
539dd57
Compare
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
tcnghia
force-pushed
the
use-dynamic-cm-informers
branch
3 times, most recently
from
17a08b5 to
1174380
Compare
|
going to close and reopen to try and kick DCO... |
Signed-off-by: Nghia Tran <[email protected]>
tcnghia
force-pushed
the
use-dynamic-cm-informers
branch
from
1174380 to
bc96bd0
Compare
mattmoor
approved these changes
Mar 16, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Use latest knative/pkg and dynamic informers Signed-off-by: Nghia Tran <[email protected]> * No need to start the informers Signed-off-by: Nghia Tran <[email protected]> * Address PR feedback Signed-off-by: Nghia Tran <[email protected]> * Run update-codegen.sh Signed-off-by: Nghia Tran <[email protected]> * Run update-codegen.sh after merge fix Signed-off-by: Nghia Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the latest version of
knative/pkgto pull in the dynamic configmap informer (knative/pkg#2466)Release Note