-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cosigned] Fix publicKey unmarshal #1719
Conversation
27e96cc
to
6dac85f
Compare
To make sure that we do not regress in the future, would you mind adding a test with public keys (existing only tests signing with Fulcio so this was not caught by the existing tests). |
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
- Coverage 29.26% 29.21% -0.05%
==========================================
Files 141 141
Lines 8503 8502 -1
==========================================
- Hits 2488 2484 -4
- Misses 5742 5744 +2
- Partials 273 274 +1
Continue to review full report at Codecov.
|
d0e658f
to
9b907b0
Compare
- Add key sign verify for cosigned github workflow Signed-off-by: Denny Hoang <[email protected]>
9b907b0
to
eff72ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesomesauce! Thanks!
- Add key sign verify for cosigned github workflow Signed-off-by: Denny Hoang <[email protected]>
Signed-off-by: Denny Hoang [email protected]
Summary
Unmarshaling PublicKeys causes an error:
Ticket Link
Fixes #1717
Notes
I am aware I am temporarily duplicating the function for parsing PEMs into the internal clusterimagepolicy_types file.
I have another branch that will address this alongside consolidating a lot of the clusterimagepolicy logic into the types file.
cc: @hectorj2f @vaikas @coyote240