Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the KMS integration imports into the binary entrypoints #1744

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Move the KMS integration imports into the binary entrypoints #1744

merged 2 commits into from
Apr 12, 2022
+12 −13

Conversation

mattmoor
Copy link
Member

Ticket Link

Related: sigstore/sigstore#384
Related: sigstore/sigstore#386

Release Note

BREAKING: if you use cosign as an SDK and rely on KMS integrations, you will need to start importing the integrations you would like to support.

@mattmoor
Copy link
Member Author

cc @imjasonh

imjasonh
imjasonh approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@mattmoor mattmoor mentioned this pull request Apr 12, 2022
Closed
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #1744 (f3b72d5) into main (0ee9d1b) will not change coverage.
The diff coverage is n/a.

❗ Current head f3b72d5 differs from pull request most recent head 2ffb7ac. Consider uploading reports for the commit 2ffb7ac to get more accurate results

@@           Coverage Diff           @@
##             main    #1744   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files         141      141           
  Lines        8505     8505           
=======================================
  Hits         2508     2508           
  Misses       5726     5726           
  Partials      271      271
Impacted Files Coverage Δ
cmd/cosign/policy_webhook/main.go 0.00% <ø> (ø)
...econciler/clusterimagepolicy/clusterimagepolicy.go 64.00% <ø> (ø)
pkg/signature/keys.go 19.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee9d1b...2ffb7ac. Read the comment docs.

@mattmoor
Remove the fake import
2ffb7ac 
Signed-off-by: Matt Moore <[email protected]>
@mattmoor mattmoor merged commit 19279dd into sigstore:main Apr 12, 2022
@mattmoor mattmoor deleted the move-imports branch April 12, 2022 20:19
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 12, 2022
@JimBugwadia JimBugwadia mentioned this pull request Apr 12, 2022
Closed
2 tasks
@priyawadhwa priyawadhwa mentioned this pull request Apr 12, 2022
Merged
@anushkamittal20 anushkamittal20 mentioned this pull request Apr 14, 2022
Merged
9 tasks
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
@mattmoor @mlieberman85
Move the KMS integration imports into the binary entrypoints (sigstor…
3e45ffd 
…e#1744)

* Move the KMS integration imports into the binary entrypoints

Related: sigstore/sigstore#384
Related: sigstore/sigstore#386
Signed-off-by: Matt Moore <[email protected]>

* Remove the fake import

Signed-off-by: Matt Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydentherapper haydentherapper haydentherapper left review comments

@dlorenc dlorenc dlorenc approved these changes

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mattmoor @codecov-commenter @imjasonh @dlorenc @haydentherapper