-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1beta1 API for cosigned #1890
v1beta1 API for cosigned #1890
Conversation
Signed-off-by: Ville Aikas <[email protected]>
Signed-off-by: Ville Aikas <[email protected]>
Signed-off-by: Ville Aikas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaikas It seems we are missing the new CRD version in config/300-clusterimagepolicy.yaml
@hectorj2f yeah, I need to figure out how to do this safely with the codegen :) |
Signed-off-by: Ville Aikas <[email protected]>
Signed-off-by: Ville Aikas <[email protected]>
I'm looking at the test failures, but it seems to not be able to get the latest release tag for scaffolding:
Notice the tag is |
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 33.35% 34.02% +0.67%
==========================================
Files 146 153 +7
Lines 9370 9936 +566
==========================================
+ Hits 3125 3381 +256
- Misses 5874 6175 +301
- Partials 371 380 +9
Continue to review full report at Codecov.
|
Signed-off-by: Ville Aikas <[email protected]>
Signed-off-by: Ville Aikas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it looks good to me. We can add the e2e tests in a different PR.
thanks @dlorenc :) |
Summary
Add v1beta1 API for cosigned.
Ticket Link
Fixes #1835
-->
Fixes
Release Note