Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fulcioroots): singleton error pattern #1965

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın [email protected]
Co-authored-by: Furkan Türkal [email protected]

Summary

feat(fulcioroots): singleton error pattern

Ticket Link

Fixes #1962

Release Note

feat(fulcioroots): singleton error pattern

cc: @Dentrax @haydentherapper

@developer-guy developer-guy force-pushed the feature/1962 branch 2 times, most recently from 067b761 to f220cce Compare June 7, 2022 08:56
Signed-off-by: Batuhan Apaydın <[email protected]>
Co-authored-by: Furkan Türkal <[email protected]>
Signed-off-by: Batuhan Apaydın <[email protected]>
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@dlorenc dlorenc merged commit 75b2bd1 into sigstore:main Jun 7, 2022
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 7, 2022
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return error instead of paniccing
4 participants