fix panic when os.Stat returns an error besides ErrNotExists #2162
Conversation
Signed-off-by: Samsondeen Dare <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2162 +/- ##
==========================================
+ Coverage 26.23% 26.70% +0.46%
==========================================
Files 130 131 +1
Lines 7617 7689 +72
==========================================
+ Hits 1998 2053 +55
- Misses 5362 5375 +13
- Partials 257 261 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Looks like this needs the boilerplate fix! |
Signed-off-by: Samsondeen Dare <[email protected]>
dsa0x
force-pushed
the
fix-panic-key-pair-perm
branch
from
e2e0c47 to
5d2b5d3
Compare
pkg/cosign/common.go
Outdated
| @@ -27,12 +27,15 @@ import ( | |||
| ) | |||
|
|
|||
| // TODO(jason): Move this to an internal package. | |||
| func FileExists(filename string) bool { | |||
| func FileExists(filename string) (bool, error) { | |||
There was a problem hiding this comment.
What do other semver folks think about this change? It's technically breaking, but I can't find any usage of it on GitHub.
There was a problem hiding this comment.
Good catch. Also, to Jason's (Todo) point, I think this should be in an internal package, as this behaviour doesn't need to be public to users. It's trivial to implement if they need to. That would prevent us from running into issues with breaking semver.
There was a problem hiding this comment.
Yeah, if we're going to change the interface we might as well move it internal at the same time to prevent future issues. WDYT about making the change?
There was a problem hiding this comment.
Sure. I can make a commit to that effect. Thanks
dsa0x
force-pushed
the
fix-panic-key-pair-perm
branch
from
4e3efd0 to
9d30c9e
Compare
dsa0x
force-pushed
the
fix-panic-key-pair-perm
branch
from
9d30c9e to
83d2391
Compare
Signed-off-by: Samsondeen Dare <[email protected]>
dsa0x
force-pushed
the
fix-panic-key-pair-perm
branch
from
83d2391 to
bf79f0d
Compare
Signed-off-by: Samsondeen Dare <[email protected]>
Signed-off-by: Samsondeen Dare <[email protected]>
Signed-off-by: Samsondeen Dare <[email protected]>
…e#2162) * fix panic when os.Stat returns an error besides ErrNotExists Signed-off-by: Samsondeen Dare <[email protected]> * boilerplate fix Signed-off-by: Samsondeen Dare <[email protected]> * move FileExists to internal package Signed-off-by: Samsondeen Dare <[email protected]> * remove archived pkg/errors Signed-off-by: Samsondeen Dare <[email protected]> * comments Signed-off-by: Samsondeen Dare <[email protected]> * comments Signed-off-by: Samsondeen Dare <[email protected]> Signed-off-by: Samsondeen Dare <[email protected]>
Signed-off-by: Samsondeen Dare [email protected]
Summary
This PR fixes a nil pointer error that occurs when
os.Statreturns an error besidesErrNotExist. The issue was also reported in #2161Release Note
bug fix: fix panic when os.Stat returns an error besides ErrNotExists
Documentation