Add missing flags to cosign verify dockerfile/manifest #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still deviations between the five verify commands. We should at some point sync all 5 with a refactoring. Fixes sigstore#2827 Signed-off-by: Hayden Blauzvern <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2830 +/- ##
==========================================
- Coverage 29.54% 29.51% -0.03%
==========================================
Files 151 151
Lines 9658 9666 +8
==========================================
Hits 2853 2853
- Misses 6366 6374 +8
Partials 439 439
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cpanato
approved these changes
Mar 23, 2023
znewman01
approved these changes
Mar 23, 2023
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
There's still deviations between the five verify commands. We should at some point sync all 5 with a refactoring. Fixes sigstore#2827 Signed-off-by: Hayden Blauzvern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still deviations between the five verify commands. We should at some point sync all 5 with a refactoring.
Fixes #2827
Summary
Release Note
Added missing verification for cosign verify dockerfile and manifest
Documentation