allow customising 'go' executable with GOEXE var #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitris
changed the title
dmitris
force-pushed
the
go-custom
branch
2 times, most recently
from
b3acbf5 to
0750440
Compare
cpanato
requested changes
Mar 25, 2023
Signed-off-by: Dmitry S <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
* Makefile: date format of log should not show signatures Signed-off-by: Vincent Batts <[email protected]> * Makefile: add the ability to DEBUG the `make` build Signed-off-by: Vincent Batts <[email protected]> --------- Signed-off-by: Vincent Batts <[email protected]>
dmitris
force-pushed
the
go-custom
branch
3 times, most recently
from
859011f to
321133a
Compare
Signed-off-by: Dmitry S <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2841 +/- ##
=======================================
Coverage 29.47% 29.47%
=======================================
Files 151 151
Lines 9678 9678
=======================================
Hits 2853 2853
Misses 6386 6386
Partials 439 439 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
addressed your feedback, please take a look @cpanato |
hectorj2f
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow customising the
goexecutable path with theGOEXEvariable setting - for example, If one needs to build a debugging version ofgoetc.gois the default value which is used ifGOEXEis not set.Release Note
NONE
Documentation
No documentation changes are needed.