implement cosign copy
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
May 11, 2021
cmd/cosign/cli/copy.go
Outdated
| func Copy() *ffcli.Command { | ||
| var ( | ||
| flagset = flag.NewFlagSet("cosign copy", flag.ExitOnError) | ||
| srcImgFlag = flagset.String("source", "", "the image (and associated signatures) to copy") |
There was a problem hiding this comment.
Do you think we need to be explicit about src and dst with named flags rather than positionals? I could see it either way.
There was a problem hiding this comment.
made it positional src dst
cmd/cosign/cli/copy.go
Outdated
|
|
||
| EXAMPLES | ||
| # copy a container image and signature | ||
| cosign copy -source example.com/foo:latest -destination example.com/bar:oldest |
There was a problem hiding this comment.
This might not be the best example since it's the same repo. It would "work" but isn't really any different than a crane cp, since the signature doesn't actually move. Maybe two repos?
Signed-off-by: Jake Sanders <[email protected]>
dlorenc
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
Signed-off-by: Jake Sanders [email protected]