-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OpenVEX predicate type #3405
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
==========================================
+ Coverage 29.70% 30.21% +0.51%
==========================================
Files 155 155
Lines 9966 9966
==========================================
+ Hits 2960 3011 +51
+ Misses 6575 6505 -70
- Partials 431 450 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where could I find more about the OpenVex predicate specification to know what to put in my attestation ?
OpenVEX is an implementation of the Vulnerability Exploitability Exchange (VEX) designed to be attestable, SBOM-agnostic and lightweight. It is hosted in the OpenSSF Vulnerability Disclosures WG and has support in popular scanners such as Trivy adn Grype. This PR adds support for openvex predicates to the `cosign attest` and `cosign download attestation` commands. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
I also added a link to our current attestation spec: https://github.com/openvex/spec/blob/main/ATTESTING.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx lgtm
Summary
This PR adds support for OpenVEX as a known predicate type to the
cosign attest
andcosign download attestation
andcosign attest-blob
commands.Instead of linking the openvex go-modules, I've hardcoded the value or the predicate URI in a const to avoid growing the dependency tree.
Resolves #3404
Release Note
openvex
as the type.Documentation
TBD
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]