Update cloud build script to latest for v1.13.x #3615
Conversation
Will use the latest Go binary and Cosign version Signed-off-by: Hayden B <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #3615 +/- ##
=============================================
Coverage 29.73% 29.73%
=============================================
Files 137 137
Lines 8560 8560
=============================================
Hits 2545 2545
Misses 5685 5685
Partials 330 330 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hayden B <[email protected]>
|
The cloud build script fails because the version of Cosign we are verifying golang-cross with can't pull down the latest metadata. Furthermore, we need to bump golang-cross to the latest (or at least a version with v2 >= 2.2.0) since we use the Cosign version installed in that container to sign the releases. |
Signed-off-by: Hayden B <[email protected]>
|
|
||
| cosign sign --force --key "gcpkms://projects/$PROJECT_ID/locations/$KEY_LOCATION/keyRings/$KEY_RING/cryptoKeys/$KEY_NAME/versions/$KEY_VERSION" -a GIT_HASH="$GIT_HASH" -a GIT_VERSION="$GIT_VERSION" $(cat cosignImagerefs) | ||
| cosign sign --force --key "gcpkms://projects/$PROJECT_ID/locations/$KEY_LOCATION/keyRings/$KEY_RING/cryptoKeys/$KEY_NAME/versions/$KEY_VERSION" -a GIT_HASH="$GIT_HASH" -a GIT_VERSION="$GIT_VERSION" $(cat sgetImagerefs) | ||
| cosign sign --yes --key "gcpkms://projects/$PROJECT_ID/locations/$KEY_LOCATION/keyRings/$KEY_RING/cryptoKeys/$KEY_NAME/versions/$KEY_VERSION" -a GIT_HASH="$GIT_HASH" -a GIT_VERSION="$GIT_VERSION" $(cat cosignImagerefs) |
There was a problem hiding this comment.
Need to update sign script too since force flag no longer exists
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
|
I think I've updated everything necessary. Let me know if this can be simplified though, because this is bumping a lot of the CI infrastructure. I think we can now use the GHA to kick off the job, but if not, from the branch, we will need to run |
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Hayden B <[email protected]>
|
I think we're good now. I didn't remove sget entirely, because that's a lot of work, but this does remove sget as a released go artifact. |
Will use the latest Go binary and Cosign version
Summary
Release Note
Documentation