-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing different SignerVerifier LoadOptions #4050
Draft
ret2libc
wants to merge
9
commits into
sigstore:main
Choose a base branch
from
trail-of-forks:use-load-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4050 +/- ##
==========================================
- Coverage 40.10% 36.94% -3.16%
==========================================
Files 155 210 +55
Lines 10044 13411 +3367
==========================================
+ Hits 4028 4955 +927
- Misses 5530 7837 +2307
- Partials 486 619 +133 ☔ View full report in Codecov by Sentry. |
I'm going to add a few tests to this. |
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
5c07a7a
to
f82ecc6
Compare
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
958259e
to
753bfc0
Compare
Signed-off-by: Riccardo Schirone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a preparation PR for #3271 and it splits some changes required to completely add support for ed25519ph, with the idea of helping the reviewers. It was split from #3479 .
Release Note
SignerFromKeyOptsWithSVOpts
,LoadPrivateKeyWithOpts
,ValidateAndUnpackCertWithOpts
,VerifyImageSignaturesWithOpts
,VerifyLocalImageSignaturesWithOpts
,VerifyBlobSignatureWithOpts
,VerifyImageSignatureWithOpts
,VerifyImageAttestationsWithOpts
,VerifyLocalImageAttestationsWithOpts
,VerifyBlobAttestationWithOpts
,VerifyImageAttestationWithOpts
,VerifierForKeyRefWithOpts
,LoadPublicKeyRawWithOpts
,SignerVerifierFromKeyRefWithOpts
,PublicKeyFromKeyRefWithOpts
.Documentation
With recent sigstore, we introduced
signature.LoadVerifierWithOpts
(and other versions forSigner
,SignerVerifier
). Adding support for ed25519ph would require passing some options around, however cosign is still usingsignature.LoadVerifier
. This PR prepares the cosign codebase to acceptLoadOptions
and pass them around, without actually changing (yet) any behaviour.Doing that required adding a lot of
*WithOpts
functions to avoid breaking other users who may rely on those exported functions. Please let me know if that's a good approach.Once this is done, we can work on a smaller PR that actually adds supports for ed25519ph and pass the correct extra
LoadOptions
around.