cmd/sign: Add -cert flag
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor abstracts away the need to directly call the upstream piv-go library, implements a common SignerVerifier interface so there is no need to maintain separate types for ECDSA and RSA private keys, and overall is more idiomatic. Additionally, it fixes an issue where the previous initialization functions would lock access to the PIV token, preventing subsequent access even if the originall caller no longer had a need to access the token. Signed-off-by: James Alseth <[email protected]>
The `-cert` flag allows for the certificate to be included in the Signature object when signing with `-key` or `-sk`. Adding this certificate ensures that a verifying party does not need to fetch the certificate from some unknown location before being able to validate the identity of the actor that created the signature. Signed-off-by: James Alseth <[email protected]>
dlorenc
approved these changes
Jul 19, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-certflag allows for the certificate to be included in theSignature object when signing with
-keyor-sk. Adding thiscertificate ensures that a verifying party does not need to fetch the
certificate from some unknown location before being able to validate the
identity of the actor that created the signature.
This also includes a refactor of the
pivkeylibrary to make it more idiomatic and to resolve an issue where callingNewPublicKeyProviderorNewSignerVerifierwould lock the PIV token until the program had exited, making future calls to the PIV token outside of the signer/verifier flow impossible.