Start to sketch internal/oci/remote.SignedImage[Index].
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mostly opening this to run the automated tests, there are still several pieces that I want to add to this, and it needs unit test coverage for some of the new functionality in Please don't merge this, or scrutinize it too much yet 😅 |
|
Ok, I think I can explain all of the failures here with a thing I already had on my TODO list, which is nice. tl;dr using I'll fix that after lunch. |
mattmoor
force-pushed
the
remote-image-index-options
branch
2 times, most recently
from
956bf2e to
54e7fe1
Compare
dekkagaijin
reviewed
Sep 17, 2021
mattmoor
force-pushed
the
remote-image-index-options
branch
3 times, most recently
from
c3ef61d to
6c9477a
Compare
mattmoor
changed the title
internal/oci/remote.SignedImage[Index].internal/oci/remote.SignedImage[Index].
This follows the pattern GGCR uses for functional `remote.Options`, and starts to define `SignedImage[Index]` methods, which build upon the `Signatures` implementation from a prior change. This also tries to start adopting this pattern a few places, which drops bits of boilerplate (or changes them to functional options). As part of this, I'm combining `FetchSignaturesForImage[Digest]` and tweaking it's signature a bit (no pun intended!), but I think long term we'll just want folks to consume the `remote` package directly themselves. Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
remote-image-index-options
branch
from
6c9477a to
b80d64c
Compare
dekkagaijin
approved these changes
Sep 18, 2021
| name: "signature option", | ||
| opts: []Option{WithSignatureSuffix(".pig")}, | ||
| want: &options{ | ||
| SignatureSuffix: ".pig", |
There was a problem hiding this comment.
ecdsa signatures end up being pretty small, actually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the pattern GGCR uses for functional
remote.Options, and starts to defineSignedImage[Index]methods, which build upon theSignaturesimplementation from a prior change.This also tries to start adopting this pattern a few places, which drops bits of boilerplate (or changes them to functional options).
As part of this, I'm combining
FetchSignaturesForImage[Digest]and tweaking it's signature a bit (no pun intended!), but I think long term we'll just want folks to consume theremotepackage directly themselves.Signed-off-by: Matt Moore [email protected]
Ticket Link
Related #666
Release Note