adds examples of signing with other tools #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ltagliaferri
requested changes
Apr 11, 2023
content/en/cosign/sign.md
Outdated
| Sign the payload with `gcloud kms`: | ||
|
|
||
| ```shell | ||
| $ gcloud kms asymmetric-sign --digest-algorithm=sha256 --input-file=payload.json --signature-file=gcpkms.sig --key=foo --keyring=foo --version=1 --location=us-central |
There was a problem hiding this comment.
Can you break this onto more than one line so it's easier for the reader (that is, so that they don't need to scroll horizontally)
There was a problem hiding this comment.
yep, just pushed up the change
content/en/cosign/sign.md
Outdated
| Base64 encode the signature and upload with `cosign`: | ||
|
|
||
| ```shell | ||
| cat gcpkms.sig | base64 | cosign attach signature --payload payload.json --signature - us-central1-docker.pkg.dev/dlorenc-vmtest2/test/taskrun |
There was a problem hiding this comment.
I would break this onto two lines too, and be more generic, like:
us-central1-docker.pkg.dev/user/test/taskrun
There was a problem hiding this comment.
yep, just pushed up the change. i noticed some others too which I've changed to be generic
Signed-off-by: ChrisJBurns <[email protected]>
ChrisJBurns
force-pushed
the
adds-other-examples-in-signing-docs
branch
from
a33d05d to
d1f879d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to deprecate https://github.com/sigstore/cosign/blob/main/EXAMPLES.md
Signed-off-by: ChrisJBurns [email protected]