Skip to content

Commit

Permalink
Require fields in legacy proto
Browse files Browse the repository at this point in the history
  • Loading branch information
haydentherapper committed Apr 15, 2022
1 parent 6db5664 commit 43878c1
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 46 deletions.
16 changes: 13 additions & 3 deletions fulcio_legacy.proto
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ syntax = "proto3";
package dev.sigstore.fulcio.v1beta;

import "google/api/annotations.proto";
import "google/api/field_behavior.proto";
import "google/api/httpbody.proto";
import "google/protobuf/empty.proto";

Expand Down Expand Up @@ -55,11 +56,17 @@ message CreateSigningCertificateRequest {
/*
* The public key to be stored in the requested certificate
*/
PublicKey publicKey = 1 [ deprecated=true ];
PublicKey publicKey = 1 [
deprecated=true,
(google.api.field_behavior) = REQUIRED
];
/*
* Proof that the client possesses the private key
*/
bytes signedEmailAddress = 2 [ deprecated=true ];
bytes signedEmailAddress = 2 [
deprecated=true,
(google.api.field_behavior) = REQUIRED
];
}

message PublicKey {
Expand All @@ -70,5 +77,8 @@ message PublicKey {
/*
* DER or PEM encoded public key
*/
bytes content = 2 [ deprecated=true ];
bytes content = 2 [
deprecated=true,
(google.api.field_behavior) = REQUIRED
];
}
2 changes: 1 addition & 1 deletion pkg/generated/protobuf/fulcio.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

87 changes: 45 additions & 42 deletions pkg/generated/protobuf/legacy/fulcio_legacy.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 43878c1

Please sign in to comment.