Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax gomod #1909

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Relax gomod #1909

merged 3 commits into from
Jan 15, 2025

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 15, 2025

Summary

Similar work done in sigstore/rekor#2323

Fixes: #1899

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.09%. Comparing base (cf238ac) to head (85d35aa).
Report is 273 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1909      +/-   ##
==========================================
- Coverage   57.93%   49.09%   -8.84%     
==========================================
  Files          50       70      +20     
  Lines        3119     5204    +2085     
==========================================
+ Hits         1807     2555     +748     
- Misses       1154     2415    +1261     
- Partials      158      234      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: cpanato <[email protected]>
@@ -1,6 +1,8 @@
module github.com/sigstore/fulcio

go 1.23.4
go 1.23.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may have to do this again after sigstore/sigstore requirements get dropped and we cut a release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked sigstore/sigstore, the version we're using here is on 1.22. @cpanato do you know what's causing the higher requirement?

@bobcallaway bobcallaway merged commit 2affb2f into sigstore:main Jan 15, 2025
13 checks passed
@cpanato cpanato deleted the relax-gomod branch January 15, 2025 13:20
@haydentherapper
Copy link
Contributor

@cpanato
Copy link
Member Author

cpanato commented Jan 17, 2025

not sure to be honest, but can check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop bumping go directive unless necessitated by other dependencies
3 participants