-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Open for testing #216
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
keyless-verification
branch
8 times, most recently
from
October 27, 2021 04:17
009f05d
to
10661c1
Compare
Ok, I think that aside from using SoftHSM, this is very nearly ready. I've gotten past a few wrinkles around validating the OIDC token, so we're past that, and it's not clearly failing trying to interact with the
|
mattmoor
force-pushed
the
keyless-verification
branch
5 times, most recently
from
October 27, 2021 20:30
4549159
to
24a98da
Compare
mattmoor
added a commit
to mattmoor/cosign
that referenced
this pull request
Oct 27, 2021
This adds a new flag to the Fulcio options to allow disabling `verifySCT` on keyless signing paths. The option is modeled after `InsecureSkipVerify` in `tls.Config` to convey the severity of disabling this verification, and the flag indicates that this is intended only for testing. This is related to my work here: sigstore/fulcio#216 Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
keyless-verification
branch
from
October 27, 2021 20:51
24a98da
to
307e557
Compare
Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
keyless-verification
branch
from
October 27, 2021 20:57
307e557
to
77aeac3
Compare
mattmoor
added a commit
to sigstore/cosign
that referenced
this pull request
Oct 27, 2021
This adds a new flag to the Fulcio options to allow disabling `verifySCT` on keyless signing paths. The option is modeled after `InsecureSkipVerify` in `tls.Config` to convey the severity of disabling this verification, and the flag indicates that this is intended only for testing. This is related to my work here: sigstore/fulcio#216 Signed-off-by: Matt Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #215.
I'm using this to test KinD on GHA.