add RFC3161 timestamp tests #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <[email protected]>
|
/cc @steiza |
haydentherapper
previously approved these changes
Dec 19, 2023
woodruffw
previously approved these changes
Dec 19, 2023
bdehamer
dismissed stale reviews from woodruffw and haydentherapper
via
5310924
bdehamer
force-pushed
the
bdehamer/tsa-tests
branch
from
5310924 to
891a894
Compare
|
This looks good to me! |
woodruffw
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one positive and one negative test for RFC3161 timestamps:
d.txt.good.sigstoreto include an RFC3161 timestamp.trusted_root.d.jsonto include the necessary timestamp authority cert chain.test_verify_rejects_bad_tsa_timestamptest case which attempts to verify a bundle containing an RFC3161 timestamp which was issued outside the validity window of the Fulcio signing certificate.