Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --trusted-root flag in conformance tests #894

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

bdehamer
Copy link
Collaborator

@bdehamer bdehamer commented Dec 8, 2023

Updates the conformance test CLI to support the new --trusted-root flag (see sigstore/sigstore-conformance#101)

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: bff2669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sigstore/conformance Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bdehamer bdehamer force-pushed the bdehamer/conformance-trust-root branch 4 times, most recently from 32448a1 to cad8867 Compare December 9, 2023 01:00
@bdehamer bdehamer force-pushed the bdehamer/conformance-trust-root branch from bc7fa0c to 8d53f5a Compare December 15, 2023 21:27
@bdehamer bdehamer force-pushed the bdehamer/conformance-trust-root branch from 8d53f5a to e06953a Compare December 15, 2023 21:54
@bdehamer bdehamer marked this pull request as ready for review December 15, 2023 22:03
@bdehamer bdehamer requested a review from a team as a code owner December 15, 2023 22:03
Copy link
Member

@feelepxyz feelepxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see some minor tweaks to the conformance lib and leveraging the different sub-packages 💯

@bdehamer bdehamer merged commit 8af9f04 into main Dec 19, 2023
24 checks passed
@bdehamer bdehamer deleted the bdehamer/conformance-trust-root branch December 19, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants