Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle rekor checkpoints w/o timestamps #999

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

bdehamer
Copy link
Collaborator

@bdehamer bdehamer commented Feb 8, 2024

Updates tlog verification logic to properly handle checkpoint values which do NOT include timestamps. This data was never being used, but the verifier would throw an error if it was missing.

related: sigstore/rekor#1888

@bdehamer bdehamer requested a review from a team as a code owner February 8, 2024 20:54
Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: cf26c12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sigstore/verify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@bdehamer bdehamer merged commit f05be96 into main Feb 8, 2024
26 checks passed
@bdehamer bdehamer deleted the bdehamer/no-checkpoint-timestamp branch February 8, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants