Remove rate limiting prober #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sigstore#309 Signed-off-by: Hayden Blauzvern <[email protected]>
cpanato
approved these changes
Dec 11, 2024
jku
reviewed
Dec 11, 2024
There was a problem hiding this comment.
seems ok, although can you explain the checksum changes (go.work.sum)? 700 new dependencies looks rough when you're just removing code...
I assume it's a result of some dependency upgrade but it looks weird (and the go tradition of only making 0.x releases doesn't help in figuring out which upgrade might be a major one)
or is this just a result of |
|
My 2c: leave this test, but perhaps take off of prod or only run on prod at a much lower interval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309
Summary
Release Note
Documentation