add fix-bundle plumbing command
#1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command enables users to fix older bundles that were malformed by older versions of sigstore-python. This changeset also includes a new integration test hierarchy, with a starter test for the new `fix-bundle` command based on a publicly observed malformed bundle. Signed-off-by: William Woodruff <[email protected]>
woodruffw
added
component:cli
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
|
Just to cross reference, we were thinking about building a similar capability in sigstore/cosign#3794, to upgrade a bundle. |
|
Confirming that I was able to get Sigstore CLI to verify all existing CPython Sigstore bundles if this process is run on them. |
di
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP; needs documentation and feedback.This command enables users to fix older bundles
that were malformed by older versions of sigstore-python.
This changeset also includes a new integration test hierarchy, with a starter test for the new
fix-bundlecommand based on a publicly observed malformed bundle.CC @sethmlarson
Closes #1088.
See python/cpython#122785.