-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/ci: add codecov #253
Conversation
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
The CI is succeeding and coverage is being uploaded to Codecov correctly, but something on their side seems to think the CI is failing and that the uploaded coverage files are empty. |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
I dug in a little more, and the uploaded report looks correct: it's a file listing, followed by the raw SQLite coverage report (from |
Codecov Report
@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage ? 70.53%
=======================================
Files ? 15
Lines ? 896
Branches ? 0
=======================================
Hits ? 632
Misses ? 264
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Well, now it's passing and uploading and generating some kind of coverage statistics, but I don't understand why. |
This reverts commit ea0f16e.
* workflows/ci: add Python 3.11 to matrix Signed-off-by: William Woodruff <[email protected]> * pyproject: add Python 3.11 classifier Signed-off-by: William Woodruff <[email protected]> Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Okay, I'm giving up on Codecov; their endpoints aren't consistently available and I'm not seeing any indication that they're consuming coverage uploads correctly. I'm going to refactor this PR to use GitHub artifacts, similar to |
Closing since the history here isn't relevant. We'll revisit this with the approach in #253 (comment) in a follow-up PR. |
See #28.
Signed-off-by: William Woodruff [email protected]