Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/ci: add codecov #253

Closed
wants to merge 18 commits into from
Closed

workflows/ci: add codecov #253

wants to merge 18 commits into from

Conversation

woodruffw
Copy link
Member

See #28.

Signed-off-by: William Woodruff [email protected]

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added component:cicd CI/CD component:tests Unit and integration tests labels Oct 17, 2022
@woodruffw woodruffw self-assigned this Oct 17, 2022
@woodruffw
Copy link
Member Author

The CI is succeeding and coverage is being uploaded to Codecov correctly, but something on their side seems to think the CI is failing and that the uploaded coverage files are empty.

Ref: codecov/codecov-action#844

@woodruffw
Copy link
Member Author

I dug in a little more, and the uploaded report looks correct: it's a file listing, followed by the raw SQLite coverage report (from coverage.py). So I'm wondering if Codecov's SQLite intake is broken; trying with XML now.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@68ec7f0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage        ?   70.53%           
=======================================
  Files           ?       15           
  Lines           ?      896           
  Branches        ?        0           
=======================================
  Hits            ?      632           
  Misses          ?      264           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@woodruffw
Copy link
Member Author

Well, now it's passing and uploading and generating some kind of coverage statistics, but I don't understand why.

@woodruffw woodruffw marked this pull request as ready for review October 17, 2022 16:36
Makefile Outdated Show resolved Hide resolved
@woodruffw woodruffw requested a review from tetsuo-cpp October 17, 2022 16:55
* workflows/ci: add Python 3.11 to matrix

Signed-off-by: William Woodruff <[email protected]>

* pyproject: add Python 3.11 classifier

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Member Author

Okay, I'm giving up on Codecov; their endpoints aren't consistently available and I'm not seeing any indication that they're consuming coverage uploads correctly.

I'm going to refactor this PR to use GitHub artifacts, similar to pyca/cryptography.

@woodruffw woodruffw marked this pull request as draft November 1, 2022 17:04
@woodruffw
Copy link
Member Author

Closing since the history here isn't relevant. We'll revisit this with the approach in #253 (comment) in a follow-up PR.

@woodruffw woodruffw closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cicd CI/CD component:tests Unit and integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants