Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosign: fix regex dependency import #411

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

Xynnn007
Copy link
Member

This is a bug fix PR. regex dependency is only used in cosign module now. Before this commit, when we only enable cosign-rustls-tls feature, the compilation will fail because regex dependency is not enabled.

Regex dependency is only used in cosign module now. Before this commit,
when we only enable `cosign-rustls-tls` feature, the compilation will
fail because regex dependency is not enabled.

Signed-off-by: Xynnn007 <[email protected]>
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@flavio flavio merged commit 037b7be into sigstore:main Oct 18, 2024
7 checks passed
@Xynnn007 Xynnn007 deleted the fix-dep-import branch October 18, 2024 17:59
flavio added a commit to flavio/sigstore-rs that referenced this pull request Feb 6, 2025
== What's Changed
* cosign: Allow use of regex in CertSubjectEmailVerifier by @dave-tucker in sigstore#300
* build(deps): bump rustsec/audit-check from 1.4.1 to 2.0.0 by @dependabot in sigstore#396
* build(deps): bump actions/checkout from 4.1.7 to 4.2.0 by @dependabot in sigstore#397
* build(deps): update rstest requirement from 0.22 to 0.23 by @dependabot in sigstore#399
* build(deps): update testcontainers requirement from 0.22 to 0.23 by @dependabot in sigstore#398
* automation: fix GHA invoking cargo audit by @flavio in sigstore#400
* Cosign | Add support for client to configure a proxy to pull signatures by @Xynnn007 in sigstore#392
* build(deps): bump actions/checkout from 4.2.0 to 4.2.1 by @dependabot in sigstore#401
* CONTRIBUTORS.md: Add note about tests and building by @jku in sigstore#404
* cosign: fix regex dependency import by @Xynnn007 in sigstore#411
* Lint tests too by @jku in sigstore#405
* Simplify cosign verify-bundle example by @jku in sigstore#408
* Examples: Add a minimal example of bundle sign/verify by @jku in sigstore#410
* build(deps): update tough requirement from 0.18 to 0.19 by @dependabot in sigstore#407
* cosign: Make verify-blob compatible with sigstore-python by @jku in sigstore#403
* build(deps): update oci-client requirement from 0.13 to 0.14 by @dependabot in sigstore#418
* build(deps): bump actions/checkout from 4.2.1 to 4.2.2 by @dependabot in sigstore#417
* Deprecate actions-rs actions by @jku in sigstore#415
* build(deps): update cached requirement from 0.53 to 0.54 by @dependabot in sigstore#421
* build(deps): update thiserror requirement from 1.0 to 2.0 by @dependabot in sigstore#420
* build(deps): bump Swatinem/rust-cache from 2.7.5 to 2.7.7 by @dependabot in sigstore#422
* fix clippy complaint by @bobcallaway in sigstore#425
* fix zizmor issues in github actions workflows by @bobcallaway in sigstore#424
* build(deps): update rstest requirement from 0.23 to 0.24 by @dependabot in sigstore#423
* Update embedded trust root by @jku in sigstore#431
* build(deps): update sigstore_protobuf_specs requirement from 0.3 to 0.4 by @dependabot in sigstore#430
* chore(deps): upgrade openidconnect by @flavio in sigstore#433

== New Contributors
* @dave-tucker made their first contribution in sigstore#300
* @jku made their first contribution in sigstore#404

**Full Changelog**: sigstore/sigstore-rs@v0.10.0...v0.11.0

Signed-off-by: Flavio Castelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants