Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url in documentation contains line breaks #393

Open
mdaniel opened this issue Nov 3, 2016 · 7 comments
Open

url in documentation contains line breaks #393

mdaniel opened this issue Nov 3, 2016 · 7 comments
Labels
documentation Documentation bug or improvement issue todo
Milestone

Comments

@mdaniel
Copy link

mdaniel commented Nov 3, 2016

Expected Behavior

A url enclosed in \url{} may be visually line-broken(?) but the hyperlink that materializes in the pdf should be the original url as authored. Or, if that's not possible then perhaps consider not line-breaking URLs so the user agent will have a better chance of making them clickable

Actual behavior

It'll be helpful when talking about the actual behavior to have this example, which I observed while reading the sile 0.9.4 pdf [its original text is on line 888 of sile.sil ]

can be found at http://www.simon-cozens.org/
content/duffers-guide-fontconfig-and-harfbuzz)

The hyperlink in Chrome, Preview, and Skim just points to the http://www.simon-cozens.org/ part. The copy-and-paste behaves correctly for Preview and Skim (that is, the text appears in the clipboard as seen immediately above), whereas Chrome takes the more literal "draw stroke here" approach and will not copy across the line boundary, making re-assembling the URL harder

@simoncozens
Copy link
Member

What's more interesting is that I have no idea why that has turned into a hyperlink.

@khaledhosny
Copy link
Contributor

These hyper links are “guessed” by some viewers, since the PDF does not contain any. There is no way to fix if we don’t want to make them hyperlinks.

@simoncozens
Copy link
Member

I guess the way to fix it is to put an explicit hyperlink in there using PDF "specials". I'll work on it.

@Omikhleia
Copy link
Member

What do we expect in this ticket?

  • \url doesn't insert an hyperlink. If some viewers make wild guesses materializing an hyperlink where we put none, and failed at doing it properly, there's nothing we can do about it, is there?
  • Our \href does insert an explicit hyperlink, and if Multi-line links and underlined contents conditional support #1334 makes it one way or another, it might even get properly line-broken.

Seems to me this ticket could be closed/rejected.

@alerque
Copy link
Member

alerque commented Mar 26, 2022

I think my expectation here is that we would update our manual generation code to explicitly make URLs into hyperlinks with no extra formatting, but clickable. The SILE manual is highly likely to be viewed on a computer screen as much or more than in print and there are quite a few URLs we could make more accessible for folks.

Beyond that the guessing behaviour of the PDF reader is clearly out of scope, and our breaking is already happening correctly. Just the link (both halves if broken) should should be added to the full url.

@alerque alerque added todo documentation Documentation bug or improvement issue labels Mar 26, 2022
@alerque alerque added this to the v0.12.x milestone Mar 26, 2022
@alerque alerque modified the milestones: v0.12.x, v0.13.x Apr 18, 2022
@alerque alerque modified the milestones: v0.13.x, v0.14.x Jun 24, 2022
@Omikhleia Omikhleia self-assigned this May 11, 2024
@Omikhleia
Copy link
Member

Since 0.15 (via #1977), links can now be line-broken, so we should be able to fix the manual accordingly.

@Omikhleia Omikhleia modified the milestones: v0.x.y, v0.15.x Jun 29, 2024
@Omikhleia Omikhleia modified the milestones: v0.15.x, v0.15.6 Oct 19, 2024
@alerque alerque modified the milestones: v0.15.6, v0.15.7 Nov 2, 2024
@Omikhleia
Copy link
Member

Removing my own assignment - I'm wont have any time for this small thing.

@Omikhleia Omikhleia removed their assignment Nov 19, 2024
@alerque alerque modified the milestones: v0.15.7, v0.15.8 Nov 25, 2024
@alerque alerque modified the milestones: v0.15.8, v0.15.9 Dec 12, 2024
@alerque alerque modified the milestones: v0.15.9, v0.15.10 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation bug or improvement issue todo
Projects
None yet
Development

No branches or pull requests

5 participants