-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typesetter and package support for constructs spanning multiple lines #1977
Conversation
N.B. Proposed on "develop" for 0.15 as the pdf changes there make it easier. Is it me or GitHub doesn't notice the "Closes XXX" text in enumerations? ^^ |
This passes all the regression and unit tests, but it won't build the manual (which is why the CI build failure). At far as code review I liked most of what I saw so far. I'm a little concerned about exposing all the public methods on |
I was thinking the same, and many other methods in the typesetters are kind of internal too. I am not fond of making them local, as I like the idea anyone can tinker with them, especially in derived classed, and was thinking of prefixes too. |
I've already been using the convention (used in many other Lua projects) of prefixing functions and variables with |
A construct for content spanning multiple lines and needing to be wrapped for some effect on each line.
cb00087
to
dab0461
Compare
bfbc84d
to
08b86a3
Compare
08b86a3
to
b0027f8
Compare
Rebase of old commits was just to tweak a commit message. The only change I actually made was the minor commit at the end to bludgeon CJK into cooperation. |
This notably affects Latin (non CJK) text in JA language because the spacer width node is computed at a different time and hence possible using a different font. This result isn't necessarily *correct* but it is not what this regression test is even testing.
New approach to #1334 (with nicer user-facing API), based on Omikhleia/silex.sile#10 -- See the latter for illustration and screenshot.
The latter being a workaround of some kind (repeating the color on each line), but at least it drastically mitigates the issue.
Caveat: It does further break the broken "pushback" logic (due to additional reboxing)