Add explicit \use command #1482

alerque · 2022-07-19T12:42:25Z

Closes #1385
Closes #1486

alerque · 2022-07-19T20:46:59Z

See discussion on naming this function in relevant #1385.

…ent, not itself

…mmands

OlivierNicole

For the math package, this looks good to me (I only looked at that), since the changes seem pretty systematic and the tests pass.

…mmands that load modules

Will enable lots of things including passing options to the inputter, processing files where the content detection might trip up, potentially ambiguous formats, multiple inputters for the same format, etc.

…mmands that load modules

…ilar functions

…imilar functions

…similar functions

…ilar functions

…10da

…with other modules This is a small step backwards in scope, but it normalizes how all different module types are instantiated so packages are not a special case with an extra argument. Realistically we didn't have the class scope isolated anyway since it was still used in the global, and long term there are better ways to pass _ENV to functions that we should be able to use to fix that scope issue. Even if we don't we would want to change *all* module types, not just one.

…stering post-init funcs

…milar functions

…s from class init

alerque added this to the v0.14.0 milestone Jul 19, 2022

alerque added the enhancement Software improvement or feature request label Jul 19, 2022

This comment was marked as outdated.

Sign in to view

alerque added 4 commits July 19, 2022 23:45

chore(manual): Change autodoc function to use content rather than arg

aa996d2

chore(classes): Change 'module' to 'require' to clarify \lua usage

3ad3de9

feat(classes): Add \use command to help deconflate \script usage

eb298c3

docs(manual): Dogfood new \use command

b2d8ad7

alerque force-pushed the package-command branch from 00d6d9c to b2d8ad7 Compare July 19, 2022 20:46

alerque changed the title ~~Add explicit \load-package command~~ Add explicit \use command Jul 19, 2022

alerque added 3 commits July 23, 2022 01:47

Merge branch 'master' into package-command

073a03e

docs(manual): Update package usage bits

3144383

chore(tests): Use new \use command throughout

451f083

alerque marked this pull request as ready for review July 22, 2022 23:25

alerque requested review from a team and simoncozens as code owners July 22, 2022 23:25

alerque added 5 commits July 24, 2022 01:31

refactor(core): Redo \use usage and add SILE.use() to be more consistent

50a0619

docs(manpage): Update man page for current usage

d76953f

feat(cli): Change --require to --use to match declarative markup

2411328

docs(manual): Update book with new CLI usage

27e0e1b

Merge branch 'master' into package-command

e34ab9b

alerque force-pushed the package-command branch from 6ced515 to 1d0e9fb Compare July 23, 2022 22:32

alerque mentioned this pull request Jul 23, 2022

De-conflate script & require #1385

Closed

alerque force-pushed the package-command branch from 1d0e9fb to 30b4c5f Compare July 23, 2022 22:49

alerque added 2 commits July 24, 2022 01:53

chore(core): Update to current \use usage throughout

6fab054

fix(utilities): Correct traceback output for SILE.error() to show par…

16b8900

…ent, not itself

alerque force-pushed the package-command branch from 30b4c5f to 16b8900 Compare July 23, 2022 22:53

alerque added 2 commits July 24, 2022 12:27

chore(classes): Use plain require() for \lua[require=foo.bar]

31be0c9

chore(classes): Normalize processing priority across input related co…

bd06191

…mmands

OlivierNicole approved these changes Jul 25, 2022

View reviewed changes

alerque mentioned this pull request Jul 26, 2022

Inputter options #1486

Closed

alerque added 3 commits July 27, 2022 00:02

fix(cli): Avoid throwing extra error on error without message

0d530a5

feat(core): Add ability to pass args to modules via \use and other co…

e64ce0f

…mmands that load modules

feat(inputters): Allow CLI to mandate inputter used for master document

1b9009f

Will enable lots of things including passing options to the inputter, processing files where the content detection might trip up, potentially ambiguous formats, multiple inputters for the same format, etc.

alerque force-pushed the package-command branch from a7b248b to 1b9009f Compare July 26, 2022 22:47

alerque added 6 commits July 27, 2022 13:00

feat(core): Add ability to pass args to modules via \use and other co…

9e54bad

…mmands that load modules

refactor(shapers): Use module naming that is easier to search for sim…

e1aa4e2

…ilar functions

refactor(inputters): Use module naming that is easier to search for s…

8f97a73

…imilar functions

refactor(outputters): Use module naming that is easier to search for …

54cb62f

…similar functions

refactor(classes): Use module naming that is easier to search for sim…

c67c2be

…ilar functions

chore(classes): Remove more traces of deprecation shims, followup c42…

09303f8

…10da

alerque force-pushed the package-command branch from 49fe3ec to 6e65883 Compare July 28, 2022 08:27

alerque added 7 commits July 28, 2022 11:53

refactor(packages): Stick with 'options' not 'args' terminology

3fd4891

test(inputters): Add test for passing options to inputter

ab106bb

chore(classes): Simplify package loading with options instead of regi…

1f2a297

…stering post-init funcs

refactor(packages): Use module naming that is easier to search for si…

43e682c

…milar functions

chore(packages): Work aruond cart-horse problem instantiating package…

4b44e01

…s from class init

chore(classes): Drop unused return code handled by Penlight constructor

63e3a3e

alerque force-pushed the package-command branch from 6e65883 to 63e3a3e Compare July 28, 2022 08:54

alerque added 2 commits July 28, 2022 13:20

feat(cli): Allow passing options to any modules specified from --use

4cdcae7

docs(manpage): Document possing module options from CLI

8e30d0b

alerque merged commit 10b333f into master Jul 28, 2022

alerque deleted the package-command branch July 28, 2022 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add explicit \use command #1482

Add explicit \use command #1482

alerque commented Jul 19, 2022 •

edited

Loading

This comment was marked as outdated.

alerque commented Jul 19, 2022

OlivierNicole left a comment

Add explicit \use command #1482

Add explicit \use command #1482

Conversation

alerque commented Jul 19, 2022 • edited Loading

This comment was marked as outdated.

alerque commented Jul 19, 2022

OlivierNicole left a comment

Choose a reason for hiding this comment

alerque commented Jul 19, 2022 •

edited

Loading