Support Lua 5.4 #929
Merged
Support Lua 5.4 #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
added
todo
ci
siffiejoe
reviewed
Jul 10, 2020
alerque
force-pushed
the
lua54
branch
3 times, most recently
from
7466188 to
a1da88e
Compare
|
The BSD build here failed, but that's not related to the PR (it doesn't even touch Lua 5.4). I'm working on that in another PR, hence I'm going to merge this with an admin override for that skipped test. Please welcome Lua 5.4 support. P.S. Note that vstruct is deliberately being installed at an old version that does not have an upper limit on the Lua version. Later releases block 5.4 even though they would work just fine. This is reported upstream here. Until that is merged we just need to hold back vstruct. All other Lua modules are the latest and greatest releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Lua related stuff I was messing with in #909 but had to put off...
Closes #668.