Update the Dockerfile to allow docker to download a sufficiently new version of oneflow #1172
Conversation
WalkthroughThe pull request introduces a modification to the Dockerfile, specifically updating the installation command for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
7-7: Add version constraints to oneflow installation.While the
-Uand--preflags will help get a newer version of oneflow, it's recommended to add version constraints to prevent potential compatibility issues with future releases.Apply this diff to add version constraints:
-RUN pip install -U --pre -f ${ONEFLOW_PIP_INDEX} ${ONEFLOW_PACKAGE_NAME} "nvidia-cudnn-cu11>=8.9,<9.0" +RUN pip install -U --pre -f ${ONEFLOW_PIP_INDEX} "${ONEFLOW_PACKAGE_NAME}>=0.9.1" "nvidia-cudnn-cu11>=8.9,<9.0"This ensures you get at least version 0.9.1 while still allowing newer versions through the
--preflag.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🔇 Additional comments (1)
Dockerfile (1)
7-8: Verify compatibility with fixed-version dependencies.
The installation uses pre-release versions of oneflow but fixed versions for other dependencies. Let's verify there are no known compatibility issues.
✅ Verification successful
Let me gather more information about the dependency versions and compatibility.
Fixed dependency versions are compatible with OneFlow
Based on the verification results:
- The
setup.pyfiles show that OneDiff is designed to work withtransformers>=4.27.1anddiffusers>=0.19.3, which means the fixed versions in the Dockerfile are compatible. - The project's README explicitly states: "You can choose the latest versions you want for diffusers or transformers."
- No compatibility issues were found in the GitHub issues search between OneFlow and these specific versions.
- The requirements files across different parts of the codebase show consistent usage of these versions, indicating they are well-tested combinations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check compatibility between oneflow and other dependencies
# Check if there are any reported issues mentioning compatibility between oneflow and the fixed versions
gh api graphql -f query='
{
search(query: "repo:siliconflow/onediff is:issue oneflow transformers-4.27.1 diffusers-0.19.3", type: ISSUE, first: 5) {
nodes {
... on Issue {
title
url
state
}
}
}
}
'
# Check if the dependencies are mentioned in any recent commits
git log --grep="transformers.*4.27.1\|diffusers.*0.19.3\|oneflow" -n 5
Length of output: 840
Script:
#!/bin/bash
# Check for any version-related configurations or requirements
fd requirements.txt --exec cat {} \;
# Look for any version constraints in setup files
fd setup.py --exec cat {} \;
# Search for any dependency version specifications in the codebase
rg -A 2 "transformers|diffusers|huggingface-hub" --type yaml --type txt
# Check if there are any version-related comments or documentation
rg "version|compatibility" README.md || true
Length of output: 6160
|
|
I copy the command from README.md. |
Did you face any issue specific to this? Some expectations:
|
#395 |
#395
this issue came from the install of oneflow==0.9, which should be >=0.9.1
Summary by CodeRabbit
oneflowpackage to allow for upgrades and pre-release versions.