Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentry logging details #392

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Fix Sentry logging details #392

merged 9 commits into from
Dec 12, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 11, 2024

IDP-779 Sentry log events are sometimes "unlabeled"


Added

  • Added the idp name to Sentry issues as a tag. This is searchable, sortable, and more visible than a context entry.

Fixed

  • Log a useful message to Sentry in cases where no explicit "message" key is included
  • Fixed one specific error instance that had neither "message" nor "error"

Changed

  • Don't report user-generated error messages (i.e. http status codes 400, 401, 404, and 409)

PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@briskt briskt requested a review from a team as a code owner December 11, 2024 08:02
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team December 11, 2024 08:02
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't understand the dependencies.json file.

application/dependencies.json Outdated Show resolved Hide resolved
@briskt briskt merged commit e887e63 into main Dec 12, 2024
4 checks passed
@briskt briskt deleted the yii2-sentry branch December 12, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants