Skip to content

Commit

Permalink
Don't duplicate hg process output (#347)
Browse files Browse the repository at this point in the history
GetTextFromQuery calls ExecuteErrorsOk, which already logs the value of
stdout and stderr to the progress dialog. So there's no point in logging
the same value a second time.
  • Loading branch information
rmunn authored Sep 7, 2024
1 parent 41c3d97 commit 4535fc4
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions src/LibChorus/VcsDrivers/Mercurial/HgRepository.cs
Original file line number Diff line number Diff line change
Expand Up @@ -468,18 +468,6 @@ private string GetTextFromQuery(string query, int secondsBeforeTimeoutOnLocalOpe
{
var result = ExecuteErrorsOk(query, secondsBeforeTimeoutOnLocalOperation);

var standardOutputText = result.StandardOutput?.Trim();
if (!string.IsNullOrEmpty(standardOutputText))
{
_progress.WriteVerbose(standardOutputText);
}

var standardErrorText = result.StandardError?.Trim();
if (!string.IsNullOrEmpty(standardErrorText))
{
_progress.WriteError(standardErrorText);
}

if (GetHasLocks())
{
_progress.WriteWarning("Hg Command {0} left lock", query);
Expand Down

0 comments on commit 4535fc4

Please sign in to comment.