Build ChorusMergeModule #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building installers Addresses #299
TODO: .gitignore nuget.exe
papeh
changed the title
There was a problem hiding this comment.
Reviewed 2 of 6 files at r5, 4 of 5 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @papeh)
build/Chorus.proj line 1 at r7 (raw file):
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build;Pack">
Unless I'm missing something this file is not needed by the GHA.
the file updater didn't work on GitHub Actions. Will try again later.
jasonleenaylor
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @papeh)
papeh
commented
Dec 8, 2022
There was a problem hiding this comment.
Reviewable status: 4 of 7 files reviewed, all discussions resolved (waiting on @jasonleenaylor)
build/Chorus.proj line 1 at r7 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Unless I'm missing something this file is not needed by the GHA.
Will be removed by #299
This reverts commit 8cb1a06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is