Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Chorus Hub Installer with GHA #314

Merged
merged 10 commits into from
Dec 12, 2022
Merged

Build Chorus Hub Installer with GHA #314

merged 10 commits into from
Dec 12, 2022

Conversation

papeh
Copy link
Contributor

@papeh papeh commented Dec 9, 2022

  • Build Chorus Hub Installer with GitHub Actions
  • Update a deprecated WiX attribute

This change is Reviewable

papeh added 2 commits December 9, 2022 11:15
* Build Chorus Hub Installer with GitHub Actions
* Update a deprecated WiX attribute
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Test Results

       6 files  ±0     321 suites  ±0   57m 1s ⏱️ - 1m 31s
   957 tests ±0     898 ✔️ ±0    59 💤 ±0  0 ±0 
3 090 runs  ±0  2 942 ✔️ ±0  148 💤 ±0  0 ±0 

Results for commit 5312d82. ± Comparison against base commit 33fd8cf.

♻️ This comment has been updated with latest results.

@papeh papeh enabled auto-merge (squash) December 9, 2022 21:37
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @papeh)

@papeh papeh merged commit 9547608 into master Dec 12, 2022
@papeh papeh deleted the fix/msbuild branch December 12, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants