Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case where port number is lost using resumable #343

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

hahn-kev
Copy link
Contributor

@hahn-kev hahn-kev commented Aug 7, 2024

previously the port number would be lost when using resumable. Meaning if the url was typed in as localhost:5158 requests would be made to localhost port 80.


This change is Reviewable

@hahn-kev hahn-kev requested review from megahirt and rmunn August 7, 2024 03:01
Copy link

github-actions bot commented Aug 7, 2024

Test Results

       4 files  ±0     412 suites  ±0   2h 45m 56s ⏱️ -4s
   883 tests +2     860 ✔️ +2    23 💤 ±0  0 ±0 
4 040 runs  +8  3 906 ✔️ +8  134 💤 ±0  0 ±0 

Results for commit 3134736. ± Comparison against base commit 104ce40.

♻️ This comment has been updated with latest results.

@megahirt
Copy link
Contributor

megahirt commented Aug 7, 2024

When i look into the GHA tests for chorus, it appears that the build-and-test on windows-latest was killed due to a 60 minute time limit. AFAICT all the windows tests passed up until the build was cancelled at 59:59.

Copy link
Contributor

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests all pass

- increase the timeout for long test runs
- also add concurrency rule to cancel outdated runs still in progress
@megahirt megahirt force-pushed the bugfix/keep-port-for-resumable-requests branch from 49a63dd to 3134736 Compare August 7, 2024 13:58
@hahn-kev hahn-kev merged commit d0b61c6 into master Aug 14, 2024
5 checks passed
@hahn-kev hahn-kev deleted the bugfix/keep-port-for-resumable-requests branch August 14, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants