Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upload- and download-artifact v4 #351

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci+cd.yml
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
@@ -66,7 +66,7 @@ jobs:

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@v4
with:
name: Test Results (${{matrix.os}})
path: "**/TestResults/*.xml"
@@ -93,7 +93,7 @@ jobs:
if: matrix.os == 'windows-latest'

- name: Upload Merge Module
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@v4
with:
name: chorus-merge-module
path: |
@@ -109,7 +109,7 @@ jobs:
if: matrix.os == 'windows-latest'

- name: Upload Chorus Hub Installer
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@v4
with:
name: chorus-hub-installer
path: |
@@ -120,7 +120,7 @@ jobs:
run: dotnet pack --no-restore --no-build -c Release

- name: Upload Artifacts
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@v4
with:
name: chorus-dotnet-nugetpackage
path: |
@@ -135,7 +135,7 @@ jobs:
if: github.event_name == 'push'
steps:
- name: Download Artifacts
uses: actions/download-artifact@fb598a63ae348fa914e94cd0ff38f362e927b741 # v3.0.0
uses: actions/download-artifact@v4
with:
path: artifacts


Unchanged files with check annotations Beta

<Directory Id="mercurial" Name="mercurial">
<Component Id="mercurial.ini" Guid="C1EEF457-E382-11DE-8A39-0800200C9A66">
<File Id="mercurial.ini" Name="mercurial.ini" Source="..\..\mercurial\mercurial.ini" />
<IniFile Id="mercurial.ini_extension_fixutf8"

Check warning on line 42 in src/Installer/ChorusHub.wxs

GitHub Actions / build-and-test (windows-latest)

ICE69: Mismatched component reference. Entry 'mercurial.ini_extension_fixutf8' of the IniFile table belongs to component 'mercurial.ini'. However, the formatted string in column 'Value' references file 'MercurialExtensions.fixutf8.fixutf8.py' which belongs to component 'MercurialExtensions.fixutf8.fixutf8.py'. Components are in the same feature.
Action="addLine"
Directory="mercurial"
Section="extensions"
<Directory Id="SystemFolder" Name="System32">
<Merge Id="CRT90" Language="1033" SourceFile="..\..\lib\Microsoft_VC90_CRT_x86.msm" DiskId="1"/>
<Merge Id="CRT90Policy" Language="1033" SourceFile="..\..\lib\policy_9_0_Microsoft_VC90_CRT_x86.msm" DiskId="1"/>

Check warning on line 123 in src/Installer/ChorusHub.wxs

GitHub Actions / build-and-test (windows-latest)

The InstallExecuteSequence table contains an action 'SxsInstallCA' which cannot be merged from the merge module '..\..\lib\policy_9_0_Microsoft_VC90_CRT_x86.msm'. This action is likely colliding with an action in the database that is being created. The colliding action may have been authored in the database or merged in from another merge module. If this is a standard action, it is likely colliding due to a difference in the condition for the action in the database and merge module. If this is a custom action, it should only be declared in the database or one merge module.

Check warning on line 123 in src/Installer/ChorusHub.wxs

GitHub Actions / build-and-test (windows-latest)

The InstallExecuteSequence table contains an action 'SxsUninstallCA' which cannot be merged from the merge module '..\..\lib\policy_9_0_Microsoft_VC90_CRT_x86.msm'. This action is likely colliding with an action in the database that is being created. The colliding action may have been authored in the database or merged in from another merge module. If this is a standard action, it is likely colliding due to a difference in the condition for the action in the database and merge module. If this is a custom action, it should only be declared in the database or one merge module.
</Directory>
</Directory>