Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download langtags with etag #1383

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

imnasnainaec
Copy link
Contributor

@imnasnainaec imnasnainaec commented Feb 6, 2025

Fixes #987 following #987 (comment)
Continues #1232 where @elisunger left off


This change is Reviewable

Copy link

github-actions bot commented Feb 6, 2025

Palaso Tests

     4 files  ± 0       4 suites  ±0   13m 53s ⏱️ -36s
 4 884 tests + 4   4 650 ✅  - 2  233 💤 + 5  1 ❌ +1 
15 906 runs  +16  15 198 ✅  - 8  704 💤 +20  4 ❌ +4 

For more details on these failures, see this check.

Results for commit e631bae. ± Comparison against base commit eec9b0b.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
SIL.WritingSystems.Tests.SldrTests ‑ LanguageTags_NewerCachedLangTagsSldrOffline_UseCachedLangTags
SIL.WritingSystems.Tests.SldrTests ‑ LanguageTags_OlderCachedLangTagsSldrOffline_UseEmbeddedLangTags
SIL.WritingSystems.Tests.SldrTests ‑ DownloadLangTags_ExistingETagNoFile
SIL.WritingSystems.Tests.SldrTests ‑ DownloadLangTags_NoPreviousETagExistingFile
SIL.WritingSystems.Tests.SldrTests ‑ DownloadLangTags_NoPreviousETagNoFile
SIL.WritingSystems.Tests.SldrTests ‑ DownloadLangTags_NotModified
SIL.WritingSystems.Tests.SldrTests ‑ DownloadLangTags_Outdated
SIL.WritingSystems.Tests.SldrTests ‑ LanguageTags_SldrOffline_UseCachedLangTags

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve how SLDR downloads langtag.json file
3 participants