-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM Version #66
ESM Version #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool of you, thanks! 💯
Could you also add the following to engines
in package.json
?
"node": "^12.20.0 || ^14.13.1 || >=16.0.0"
As recommended by Sindre Sorhus' ESM migration guide.
Also, could you please make a sanity check whether it works as a package? You can do it with yalc, install it globally, then in this project run yalc publish
(acts as npm publish
), and in your test project run yalc add @silvenon/remark-smartypants
(like npm install
). Then try to use it and let me know if it works 🤞 thanks again very much!
I tested it with astro.build and works perfectly. Also, I added JSDocs and TypeScript definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiice! 🥇 🚀
Published! |
Given that all the dependencies of this package have become ESM only, it may be appropriate to release a v2.0 as ESM only too
Note: the addition of
cross-env
was needed to enable ESM for Jest (reference: https://jestjs.io/docs/ecmascript-modules)