Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM Version #66

Merged
merged 6 commits into from
Nov 21, 2021
Merged

ESM Version #66

merged 6 commits into from
Nov 21, 2021

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Nov 20, 2021

Given that all the dependencies of this package have become ESM only, it may be appropriate to release a v2.0 as ESM only too

Note: the addition of cross-env was needed to enable ESM for Jest (reference: https://jestjs.io/docs/ecmascript-modules)

Copy link
Owner

@silvenon silvenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool of you, thanks! 💯

Could you also add the following to engines in package.json?

"node": "^12.20.0 || ^14.13.1 || >=16.0.0"

As recommended by Sindre Sorhus' ESM migration guide.

Also, could you please make a sanity check whether it works as a package? You can do it with yalc, install it globally, then in this project run yalc publish (acts as npm publish), and in your test project run yalc add @silvenon/remark-smartypants (like npm install). Then try to use it and let me know if it works 🤞 thanks again very much!

package.json Outdated Show resolved Hide resolved
@JuanM04
Copy link
Contributor Author

JuanM04 commented Nov 20, 2021

Also, could you please make a sanity check whether it works as a package?

I tested it with astro.build and works perfectly.

Also, I added JSDocs and TypeScript definitions

Copy link
Owner

@silvenon silvenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiice! 🥇 🚀

@silvenon silvenon merged commit d733e05 into silvenon:master Nov 21, 2021
@silvenon silvenon mentioned this pull request Nov 21, 2021
@silvenon
Copy link
Owner

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants