fix code format

Signed-off-by: silverbullet233 <[email protected]>
silverbullet233 · Feb 6, 2025 · ffc61db · ffc61db
1 parent 2ec23b4
commit ffc61db
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 10 deletions.
diff --git a/be/src/common/config.h b/be/src/common/config.h
@@ -1566,6 +1566,8 @@ CONF_mInt32(json_parse_many_batch_size, "1000000");
 CONF_mBool(enable_dynamic_batch_size_for_json_parse_many, "true");
 CONF_mInt32(put_combined_txn_log_thread_pool_num_max, "64");
 CONF_mBool(enable_put_combinded_txn_log_parallel, "false");
+// some internal parameters are used to control the execution strategy of join runtime filter pushdown.
+// Do not modify them unless necessary.
 CONF_mInt64(rf_sample_rows, "1024");
 CONF_mInt64(rf_sample_ratio, "32");
 CONF_mInt64(rf_branchless_ratio, "8");

diff --git a/be/src/exec/olap_scan_prepare.cpp b/be/src/exec/olap_scan_prepare.cpp
@@ -30,9 +30,9 @@
 #include "storage/column_predicate.h"
 #include "storage/predicate_parser.h"
 #include "storage/predicate_tree/predicate_tree.hpp"
+#include "storage/runtime_filter_predicate.h"
 #include "storage/runtime_range_pruner.h"
 #include "storage/runtime_range_pruner.hpp"
-#include "storage/runtime_filter_predicate.h"
 #include "types/date_value.hpp"
 #include "types/logical_type.h"
 #include "types/logical_type_infra.h"

diff --git a/be/src/exec/olap_scan_prepare.h b/be/src/exec/olap_scan_prepare.h
@@ -21,8 +21,8 @@
 #include "runtime/descriptors.h"
 #include "storage/predicate_tree/predicate_tree_fwd.h"
 #include "storage/predicate_tree_params.h"
-#include "storage/runtime_range_pruner.h"
 #include "storage/runtime_filter_predicate.h"
+#include "storage/runtime_range_pruner.h"
 
 namespace starrocks {
 

diff --git a/be/src/storage/rowset/rowset_options.h b/be/src/storage/rowset/rowset_options.h
@@ -23,8 +23,8 @@
 #include "storage/olap_common.h"
 #include "storage/options.h"
 #include "storage/predicate_tree/predicate_tree.hpp"
-#include "storage/runtime_range_pruner.h"
 #include "storage/runtime_filter_predicate.h"
+#include "storage/runtime_range_pruner.h"
 #include "storage/seek_range.h"
 #include "storage/tablet_schema.h"
 

diff --git a/be/src/storage/rowset/segment_iterator.cpp b/be/src/storage/rowset/segment_iterator.cpp
@@ -59,9 +59,9 @@
 #include "storage/rowset/rowid_column_iterator.h"
 #include "storage/rowset/segment.h"
 #include "storage/rowset/short_key_range_option.h"
+#include "storage/runtime_filter_predicate.h"
 #include "storage/runtime_range_pruner.h"
 #include "storage/runtime_range_pruner.hpp"
-#include "storage/runtime_filter_predicate.h"
 #include "storage/types.h"
 #include "storage/update_manager.h"
 #include "types/array_type_info.h"

diff --git a/be/src/storage/rowset/segment_options.h b/be/src/storage/rowset/segment_options.h
@@ -25,8 +25,8 @@
 #include "storage/disjunctive_predicates.h"
 #include "storage/options.h"
 #include "storage/predicate_tree/predicate_tree.hpp"
-#include "storage/runtime_range_pruner.h"
 #include "storage/runtime_filter_predicate.h"
+#include "storage/runtime_range_pruner.h"
 #include "storage/seek_range.h"
 #include "storage/tablet_schema.h"
 

diff --git a/be/src/storage/tablet_reader_params.h b/be/src/storage/tablet_reader_params.h
@@ -24,8 +24,8 @@
 #include "storage/chunk_iterator.h"
 #include "storage/olap_common.h"
 #include "storage/predicate_tree/predicate_tree.hpp"
-#include "storage/runtime_range_pruner.h"
 #include "storage/runtime_filter_predicate.h"
+#include "storage/runtime_range_pruner.h"
 #include "storage/tuple.h"
 
 namespace starrocks {

diff --git a/be/test/exprs/runtime_filter_test.cpp b/be/test/exprs/runtime_filter_test.cpp
@@ -956,11 +956,13 @@ void test_pipeline_level_helper(TRuntimeFilterBuildJoinMode::type join_mode, con
         return [is_reduce, layout, num_rows, num_partitions](BinaryColumn* column, std::vector<uint32_t>& hash_values,
                                                              std::vector<size_t>& num_rows_per_partitions) {
             if (is_reduce) {
-                dispatch_layout<WithModuloArg<ReduceOp>::HashValueCompute>(
-                        true, layout, std::vector<const Column*>{column}, num_rows, num_partitions, hash_values);
+                dispatch_layout<WithModuloArg<ReduceOp, FullScanIterator>::HashValueCompute>(
+                        true, layout, std::vector<const Column*>{column}, num_partitions,
+                        FullScanIterator(hash_values, num_rows));
             } else {
-                dispatch_layout<WithModuloArg<ModuloOp>::HashValueCompute>(
-                        true, layout, std::vector<const Column*>{column}, num_rows, num_partitions, hash_values);
+                dispatch_layout<WithModuloArg<ModuloOp, FullScanIterator>::HashValueCompute>(
+                        true, layout, std::vector<const Column*>{column}, num_partitions,
+                        FullScanIterator(hash_values, num_rows));
             }
             for (auto v : hash_values) {
                 if (v != BUCKET_ABSENT) {