-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a configuration for linting commit messages #44
Changes from all commits
777f090
0034b96
44e2682
5dbed85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,4 @@ before_install: if [[ `npm -v` != 6* ]]; then npm i -g [email protected]; fi | |
|
||
script: | ||
- grunt standards | ||
- commitlint-travis |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
extends: [ './commitlint.js' ], | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
rules: { | ||
'body-leading-blank': [ 2, 'always' ], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As team decided on Slack: add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For posterity: this matches our comments max line length There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And thus, let's also add |
||
'body-max-line-length': [ 2, 'always', 90 ], | ||
'footer-leading-blank': [ 2, 'always' ], | ||
'footer-max-line-length': [ 2, 'always', 90 ], | ||
'header-max-length': [ 2, 'always', 72 ], | ||
'scope-case': [ 2, 'always', [ 'lower-case', 'kebab-case' ] ], | ||
'scope-empty': [ 2, 'always' ], | ||
'subject-case': [ | ||
2, | ||
'never', | ||
[ 'upper-case' ], | ||
], | ||
'subject-empty': [ 2, 'never' ], | ||
'subject-full-stop': [ 2, 'never', '.' ], | ||
'type-case': [ 2, 'always', 'lower-case' ], | ||
'type-empty': [ 2, 'never' ], | ||
'type-enum': [ | ||
2, | ||
'always', | ||
[ | ||
'build', | ||
'chore', | ||
'ci', | ||
'docs', | ||
'feat', | ||
'fix', | ||
'perf', | ||
'refactor', | ||
'revert', | ||
'style', | ||
'test', | ||
], | ||
], | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a weird comment here:
GitHub won't let me comment on that file because there's no lines in it ... and it doesn't really indicate what it is. Is it a symlink to allow for referencing
@silvermine/eslint-config/commitlint
without needing to reference the*.config.js
file specifically?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't be there. I must have created it by accident somehow. I removed it.