Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit message standards to reflect conventional-changelog acceptance #8

Open
jthomerson opened this issue Feb 25, 2019 · 1 comment

Comments

@jthomerson
Copy link
Member

In lambda-express we have started using conventional-changelog syntax for our commit messages, and enforcing it in our linting. We use commits to bump versions correctly and generate changelogs. If we decide we like that format, we will need to update our coding standards here to document it.

When updating the standards, be sure to explicitly state:

  • line lengths
  • types / scopes
  • indentation (e.g. starting lines after BREAKING CHANGE:\n with four spaces so that they get properly indented in the changelog list item - probably the same for lists that we explicitly write in our commit bodies, too)
  • format for referencing multiple issues
@jthomerson
Copy link
Member Author

Make sure to include all the stuff we commented on and codified in this PR:

https://github.com/silvermine/eslint-config-silvermine/pull/44/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant