Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdminUser::isAuthenticated logic to work properly when app 2fa is disabled #101

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

gauthierm
Copy link
Member

Testing

  1. check out this PR on berna
  2. Go to course host dir on berna
  3. yarn start --symlinks=admin
  4. Visit https://berna.silverorange.com/course-host/work-[my-folder]/www/admin/
  5. Sign in should work
  6. Go to emrap dir on berna
  7. yarn start --symlinks=admin
  8. Visit https://berna.silverorange.com/emrap/work-[my-folder]/www/admin/
  9. Sign in should work

@gauthierm gauthierm merged commit 159642c into silverorange:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant