Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add origin admin #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add origin admin #157

wants to merge 1 commit into from

Conversation

pparke
Copy link
Contributor

@pparke pparke commented Apr 4, 2023

Adds a custom field that braintree can check in order to exempt admin orders from fraud protection

gauthierm
gauthierm reviewed Apr 17, 2023
View reviewed changes
Store/StoreBraintreePaymentProvider.php
'site_title' => $this->truncateField($this->site_title, 255),
'order_description' => $this->truncateField(
$this->getOrderDescription($order),
255
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't drop trailing comma

@gauthierm
Copy link
Member

The custom field set up in Braintree has the user-visible name Origin Admin. This is not really clear for humans. Consider a name like Order Placed by Admin

@gauthierm
Copy link
Member

I'm not sure if we need this field. See https://developer.paypal.com/braintree/docs/guides/premium-fraud-management-tools/server-side#skipping-premium-fraud-management-tools

If you're looking to configure CVV or AVS checks based on a custom field, I do not think that is possible.

gauthierm
gauthierm requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@gauthierm gauthierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR feedback

@gauthierm
Copy link
Member

We already have an origin field on orders in the Rap package. If this approach is necessary, the existing flag should be used rather than adding a second flag.

@kendraSO
Copy link
Contributor

kendraSO commented May 9, 2023

I'm not sure if we need this field. See https://developer.paypal.com/braintree/docs/guides/premium-fraud-management-tools/server-side#skipping-premium-fraud-management-tools

If you're looking to configure CVV or AVS checks based on a custom field, I do not think that is possible.

I checked in with our contact at Braintree and they said skipAdvancedFraudChecking would work for what we're looking to do here. This does bypass their checks completely compared to the custom field that they would have to set to ignore on their side of things.

We had previously asked about scaExemption and that one does not skip their checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauthierm gauthierm gauthierm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pparke @gauthierm @kendraSO