-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] Use Swiftype for search #176
Comments
FYI: "Uses the same swiftype account as silverstripe.org & silverstripe.com" should probably added as a specific AC. If this winds up polluting search results between main site search and docs search, IMO that's fine, as the distinction between the two is more relevant to us than our users tbh. ;-) |
Added :) |
Related: silverstripe/api.silverstripe.org#73 |
Oh here's a good example: Search for |
As a test, I've enabled docs.silverstripe.org in swiftype with:
|
We're relying on /en/3/changelogs for the SS3 changelogs and /en/4/changelogs for the SS4 changelogs though right? Relevant: silverstripe/silverstripe-framework#8035 |
I blacked listed them due to this AC. We can always tweak later:
|
Ha, right |
Swiftype has only managed to index 2 page (en/3/all and en/4/all). I suspect that this may be related. silverstripe/silverstripe-docsviewer#148 |
OK links are now root-relative on docs.silverstripe.org. We'll check back in a day to see if it can index more than 4 pages. |
That didn't fix it, Swiftype supported suggested that this might be causing issues #180. |
Note that @lexakami has just rolled out SwiftType to silverstripe.org, docs, userhelp, and addons. I don't think those search facets would include each respective site's content, however, but at least the buttons isn't broken any more. I've closed all the other issues in favour of this one, so we can track any further changes required here. |
Closing as we went with Algolia docsearch. |
…ix-userdoc-deploy MNT Fix github action for deploying userdocs
Overview
The current search is useless: It indexes changelogs, which leads to a large amount of irrelevant results. It also uses a one-off search solution (Lucene PHP), which is hard to maintain and customise. While we could fix the short-term issues, there's little value in keeping a custom search engine overall - particularly now that we have Swiftype across silverstripe.com and silverstripe.org already.
Acceptance Criteria
versioned_gridfield_extensions
,SilverStripe\Security\Member
orDB::query
)Notes
docs/en
for 4.x (242 of those are changelogs)api.silverstripe.org/4/*
The text was updated successfully, but these errors were encountered: