ENH Update reference to supported modules data #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuySartorelli is attempting to deploy a commit to the SilverStripe Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emteknetnz
requested changes
May 8, 2024
| "silverstripe/silverstripe-userhelp-content", | ||
| "silverstripe/demo.silverstripe.org", | ||
| "silverstripe/silverstripe-frameworktest", | ||
| "silverstripe/developer-docs", |
There was a problem hiding this comment.
Shouldn't this list by dynamically read from the supported-modules repo?
There was a problem hiding this comment.
Not on every request, no. This file gets rebuilt based on the supported-modules repo data on each deployment, as per the information in the readme. This is the way it has always worked.
We just need to make sure to trigger a deployment if we update the list, which was already required before this PR anyway. I'm not inclined to change the way that works in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer hardcoding repos - the supported-modules list has all the repos we care about.
Added "other" category, so maintenance repos aren't dumped into the "supported" list.
Issue