Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Remove unsupported modules #43

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

emteknetnz
Copy link
Member

Issue #29

Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

phpunit.xml.dist Outdated
@@ -71,8 +64,6 @@
<testsuite name="recipe-blog">
<directory>vendor/silverstripe/blog/tests</directory>
<directory>vendor/silverstripe/lumberjack/tests</directory>
<directory>vendor/silverstripe/widgets/tests</directory>
<directory>vendor/silverstripe/content-widget/tests</directory>
<directory>vendor/silverstripe/spamprotection/tests</directory>
<directory>vendor/silverstripe/comments/tests</directory>
<directory>vendor/silverstripe/comment-notifications/tests</directory>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the two comment test suite be removed as well?

Copy link
Member Author

@emteknetnz emteknetnz Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. updated

Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 79cc14d into silverstripe:5 Jun 12, 2023
@GuySartorelli GuySartorelli deleted the pulls/5/remove branch June 24, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants