-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP Remove unsupported modules #43
DEP Remove unsupported modules #43
Conversation
616e61e
to
38c41f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
phpunit.xml.dist
Outdated
@@ -71,8 +64,6 @@ | |||
<testsuite name="recipe-blog"> | |||
<directory>vendor/silverstripe/blog/tests</directory> | |||
<directory>vendor/silverstripe/lumberjack/tests</directory> | |||
<directory>vendor/silverstripe/widgets/tests</directory> | |||
<directory>vendor/silverstripe/content-widget/tests</directory> | |||
<directory>vendor/silverstripe/spamprotection/tests</directory> | |||
<directory>vendor/silverstripe/comments/tests</directory> | |||
<directory>vendor/silverstripe/comment-notifications/tests</directory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the two comment test suite be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. updated
38c41f1
to
891be0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #29