FIX Don't require jquery on the frontend #2854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of this javascript is actually used in the built-in silverstripe navigator functionality anymore - but someone might be relying on this javascript being there, so just removing the file would be a breaking change. Instead, I've rewritten the jquery functionality using pure javascript.
You can test it using this in a template. The new js should behave the same way the old js did in 4.11. Note that the popup css puts the popup above the visible area of the window by default, so I've added an
!important
style to the element below to counteract this for testing purposes.Issue